Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use since param when querying ResultsDB #362

Closed
jskladan opened this issue Aug 25, 2015 · 1 comment
Closed

Use since param when querying ResultsDB #362

jskladan opened this issue Aug 25, 2015 · 1 comment
Labels
API Issues related to Bodhi's REST API Composer Issues related to the composer JS Issues pertaining to Bodhi's JavaScript code

Comments

@jskladan
Copy link

You query ResultsDB for all the results available for the particular update. That is not "wrong" per-se, but when an update is changed, after the tests are finished, you might be showing (e.g.) PASSED result for Depcheck, although it is more like "not tested yet".

ResultsDB's query engine supports since param, that takes a timestamp in ISO8601(YYYY-MM-DDTHH:MM:SS) format, and when used ResultsDB only returns results that are newer than the datetime specified.

I'm not sure if the update has something like "last modified" value, but if the last-modified is anything else than "created at", I'd suggest using the since param, to ensure the right information is shown.

@ralphbean
Copy link
Contributor

👍 good idea.

@ralphbean ralphbean added Composer Issues related to the composer API Issues related to Bodhi's REST API JS Issues pertaining to Bodhi's JavaScript code labels Aug 25, 2015
ralphbean added a commit that referenced this issue Aug 26, 2015
ralphbean added a commit that referenced this issue Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues related to Bodhi's REST API Composer Issues related to the composer JS Issues pertaining to Bodhi's JavaScript code
Projects
None yet
Development

No branches or pull requests

2 participants