This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ralphbean
This branch contains changes required to be made to the repo for the purpose of packaging it.
Here's an initial SPEC file written: https://gist.github.com/rtnpro/20075dd4df631729d898
I am a bit confused about the files under
fedmsg.d/
dir? Is it only for development. As I see, the files in thefedmsg
dir conflicts with the ones installed byfedmsg
RPM package. Am I supposed to include onlyfedmsg.d/statscache.py
in the package? What about logging conf?Or, shall I exclude them from the package totally and
ansible
scripts take care of them, as done in, https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/datagrepper/tasks/main.yml.Please have a look and comment.