Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Statscache packaging #16

Merged
merged 1 commit into from Jun 24, 2015
Merged

Statscache packaging #16

merged 1 commit into from Jun 24, 2015

Conversation

rtnpro
Copy link
Contributor

@rtnpro rtnpro commented Jun 21, 2015

@ralphbean

This branch contains changes required to be made to the repo for the purpose of packaging it.

Here's an initial SPEC file written: https://gist.github.com/rtnpro/20075dd4df631729d898
I am a bit confused about the files under fedmsg.d/ dir? Is it only for development. As I see, the files in the fedmsg dir conflicts with the ones installed by fedmsg RPM package. Am I supposed to include only fedmsg.d/statscache.py in the package? What about logging conf?
Or, shall I exclude them from the package totally and ansible scripts take care of them, as done in, https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/datagrepper/tasks/main.yml.
Please have a look and comment.

@ralphbean
Copy link
Contributor

Am I supposed to include only fedmsg.d/statscache.py in the package

Yes, just this file should do it.

We could also use sed in the %prep section to change the 'True' to 'False' in that file, so that it is not automatically enabled (or not.. your choice).

@ralphbean
Copy link
Contributor

Note that, even though we'll ship a /etc/fedmsg.d/statscache.py as an example with the package, we will still overwrite it with ansible so that we can point it at our actual postgres db, not a sqlite database.

@rtnpro
Copy link
Contributor Author

rtnpro commented Jun 22, 2015

@ralphbean what do I do about logging.py? I cannot put it in /etc/fedmsg.d/. We have logging for statscache in our local fedmsg.d/logging.py.

@ralphbean
Copy link
Contributor

@rtnpro oh, it can just be ignored. I'm fairly certain it is just a copy of the default /etc/fedmsg.d/logging.py.

There is some statscache-specific logging configuration in fedmsg.d/statscache.py, though.

Added apache and fedmsg files in MANIFEST.in
@rtnpro
Copy link
Contributor Author

rtnpro commented Jun 22, 2015

@rtnpro
Copy link
Contributor Author

rtnpro commented Jun 23, 2015

@ralphbean Is it good to be merged?

@ralphbean
Copy link
Contributor

Yup! 👍 here. Go for it.

rtnpro added a commit that referenced this pull request Jun 24, 2015
@rtnpro rtnpro merged commit d491239 into develop Jun 24, 2015
@ralphbean ralphbean deleted the packaging branch June 24, 2015 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants