Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch date links #43

Closed
kparal opened this issue Jun 22, 2015 · 9 comments
Closed

Catch date links #43

kparal opened this issue Jun 22, 2015 · 9 comments
Assignees
@cydrobolt
Labels
T: improvement Improves on something that already exists

Comments

@kparal
Copy link

kparal commented Jun 22, 2015

In bugzilla, we have many comments like these:

Discussed at today's blocker review meeting [1].

This bug was rejected as blocker: This bug doesn't appear often enough to 
warrant blocking release. If this bug starts to show up on more platforms
please repropose.

[1] http://meetbot.fedoraproject.org/fedora-blocker-review/2015-05-18

It would be great if the historical links worked, if possible. Currently they return 404. Thanks.
@kparal
Copy link
Author

kparal commented Jun 22, 2015

Sometimes we linked the directory, sometimes the particular txt/html file.

@cydrobolt cydrobolt added the T: improvement Improves on something that already exists label Jun 22, 2015
@cydrobolt cydrobolt changed the title Don't break existing links Catch date links Jun 22, 2015
@cydrobolt
Copy link
Contributor

I'm going to work on this, hopefully get it fixed soon

@cydrobolt cydrobolt self-assigned this Jun 22, 2015
@cydrobolt
Copy link
Contributor

Fixed in dbc9d33, will be pushed soon.

@cydrobolt
Copy link
Contributor

Deployed

@kparal
Copy link
Author

kparal commented Jun 24, 2015

Thanks.

@cydrobolt cydrobolt mentioned this issue Jun 24, 2015
Closed
@AdamWill
Copy link

Note, it still doesn't handle directories with a trailing slash. Compare http://meetbot.fedoraproject.org/fedora-blocker-review/2015-05-18 and http://meetbot.fedoraproject.org/fedora-blocker-review/2015-05-18/ .

@cydrobolt
Copy link
Contributor

Yeah, we haven't deployed the new patch yet.

On Fri, Jun 26, 2015, 8:31 PM Adam Williamson notifications@github.com
wrote:

Note, it still doesn't handle directories with a trailing slash. Compare
http://meetbot.fedoraproject.org/fedora-blocker-review/2015-05-18 and
http://meetbot.fedoraproject.org/fedora-blocker-review/2015-05-18/ .

—
Reply to this email directly or view it on GitHub
#43 (comment).

@cydrobolt
Copy link
Contributor

There was another commit earlier that fixed the trailing slash thing.

On Fri, Jun 26, 2015, 8:39 PM Chaoyi Zha summermontreal@gmail.com wrote:

Yeah, we haven't deployed the new patch yet.

On Fri, Jun 26, 2015, 8:31 PM Adam Williamson notifications@github.com
wrote:

Note, it still doesn't handle directories with a trailing slash. Compare
http://meetbot.fedoraproject.org/fedora-blocker-review/2015-05-18 and
http://meetbot.fedoraproject.org/fedora-blocker-review/2015-05-18/ .

—
Reply to this email directly or view it on GitHub
#43 (comment).

@cydrobolt
Copy link
Contributor

Deployed fix for trailing slashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cydrobolt cydrobolt

Labels
T: improvement Improves on something that already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kparal @AdamWill @cydrobolt