Umdl delete #95
Merged
Umdl delete #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since being ported to MM2 umdl's --delete functionality has never been used and was still using the old and now not-existing SQLObject interface. Change it to use the SQLAlchemy interface. Running umdl with --delete decreases the size of the Fedora MM instance database dump from 800MB to 760MB.
For the previous commit "Re-Enable --delete functionality in umdl" to work the delete of a Directory object has to be cascaded through all the other database tables which are referencing the deleted Directory object.
|
Simple enough, 👍 for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure this 100% correct, but this are the minimal changes to make umdl's delete option work again. Running umdl with --delete in Fedora's MM staging instance reduces the size of a database dump from 800MB to 760MB.