Get a release ready with python3 support. #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the work done by @bkabrda to port the crypto module to python3.
We found that:
So this pull request introduces an (ugly) split. If we're on py3, we use an
x509_ng module that uses cryptography for signing .. and will fail to validate
anything with an
ImportError
on M2Crypto. If we're on py2, then we use theold standard x509 module.
I'd like to release this so we can try it with mailman3 which is python3 only.
We have a plugin for it
that only publishes (signs) messages, but does not receive (validate) them, so
we should be okay.