Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a release ready with python3 support. #343

Merged
merged 7 commits into from Jun 25, 2015
Merged

Conversation

ralphbean
Copy link
Contributor

This includes the work done by @bkabrda to port the crypto module to python3.
We found that:

  • M2Crypto won't be ported to python3, so we need something else.
  • python-cryptography looks nice.
  • It can only do the message-signing part of what we need, not message validation.

So this pull request introduces an (ugly) split. If we're on py3, we use an
x509_ng module that uses cryptography for signing .. and will fail to validate
anything with an ImportError on M2Crypto. If we're on py2, then we use the
old standard x509 module.

I'd like to release this so we can try it with mailman3 which is python3 only.
We have a plugin for it
that only publishes (signs) messages, but does not receive (validate) them, so
we should be okay.

@pypingou
Copy link
Member

Looks fine to me

@bkabrda
Copy link
Contributor

bkabrda commented Jun 25, 2015

👍 Cool!

ralphbean added a commit that referenced this pull request Jun 25, 2015
Get a release ready with python3 support.
@ralphbean ralphbean merged commit c4808d8 into develop Jun 25, 2015
@ralphbean ralphbean deleted the feature/py34-finish branch June 25, 2015 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants