Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Update utils.py #25

Closed
wants to merge 1 commit into from
Closed

Update utils.py #25

wants to merge 1 commit into from

Conversation

adsnjhfyeqw231eas
Copy link

json object returned in #24

json object returned in #24
@ralphbean
Copy link
Contributor

I'm confused about this change. Can you explain the reasoning behind it?

@pypingou
Copy link
Member

@TridevGuha did you see @ralphbean's question?

@ralphbean
Copy link
Contributor

I'm pretty sure that returning a str from strip_tags(...) instead of a dict is not what we want to do. So, I'm going to close this. @TridevGuha, if you want to explain and re-open it, feel free!

@ralphbean ralphbean closed this Jan 29, 2016
@adsnjhfyeqw231eas
Copy link
Author

OK @ralphbean , I just returned the json object.

@ralphbean
Copy link
Contributor

json.dumps returns a string in python. Any other code that previously called that function and tried to work with the return value would probably stop working. Before it was returning a dict and now it would be returning a str -- those things behave quite differently.

@adsnjhfyeqw231eas adsnjhfyeqw231eas deleted the patch-1 branch January 30, 2016 02:40
@adsnjhfyeqw231eas
Copy link
Author

@ralphbean thanks, I will try to know more about it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants