This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Improve the package request page to support giving only a ticket id #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fields Once we successfully retrieved the info from the review server, we disable the package name and package summary to be sure there is no discrepancy between pkgdb and bugzilla. The fields are enabled if we failed to retrieve information from the review server.
| var _bzurl = $('#review_url').val(); | ||
| var _bzid = null; | ||
| if (_bzurl.indexOf("?id=") > -1) { | ||
| _bzid = _bzurl.split("?id=")[1]; | ||
| var _bzidint = false; |
There was a problem hiding this comment.
It looks like you set _bzidint here, but then never use it.
There was a problem hiding this comment.
true, I had an idea but turned out to be un-necessary, will drop it
| _bzid = _bzurl.split("?id=")[1]; | ||
| if ($.isNumeric(_bzurl)) { | ||
| _bzid = _bzurl; | ||
| _bzidint = true; |
There was a problem hiding this comment.
Still setting _bzidint here.
|
OK, 👍 |
|
Thanks for the review! |
pypingou
added a commit
that referenced
this pull request
Oct 7, 2015
Improve the package request page to support giving only a ticket id
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229