Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No feedback when trying to add karma without entering a comment. #375

Closed
jwakely opened this issue Aug 26, 2015 · 4 comments
Closed

No feedback when trying to add karma without entering a comment. #375

jwakely opened this issue Aug 26, 2015 · 4 comments
Labels
JS Issues pertaining to Bodhi's JavaScript code

Comments

@jwakely
Copy link
Contributor

jwakely commented Aug 26, 2015

If I click the radio button to say the update is generally functional and click the "Add comment" button nothing happens.

It seems to refuse to submit unless I type something in the comment textbox, but there is no error or feedback telling me that.
@ralphbean ralphbean added the JS Issues pertaining to Bodhi's JavaScript code label Aug 26, 2015
@ralphbean
Copy link
Contributor

OH! I see. What browser are you using?

We use the <textarea required="true"/> HTML5 attribute which should prompt your browser to say "you have to fill this in".

@jwakely
Copy link
Contributor Author

jwakely commented Aug 26, 2015

This was with Firefox 40.0 from Fedora 22.

@jwakely
Copy link
Contributor Author

jwakely commented Aug 26, 2015

Hmm, now I see a (fairly subtle) "please fill in this field" alert ... I wonder if that was there before and I missed it. I've just been playing with it, and don't see how I would have missed it (it appears pretty close to where I must have been looking in order to click on the button) but I have no other explanation other than PEBKAC.

@jwakely jwakely closed this as completed Aug 26, 2015
@ralphbean
Copy link
Contributor

Thanks @jwakely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JS Issues pertaining to Bodhi's JavaScript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralphbean @jwakely