A gerrit service. #305
Merged
A gerrit service. #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphbean
force-pushed
the
feature/gerrit
branch
from
b1d6c92
to
0d6a9f7
Compare
|
Did you intend to commit gerrit.py? |
| url = self.url + '/a/changes/' + \ | ||
| '?q=is:open+is:reviewer' + \ | ||
| '&o=MESSAGES&o=DETAILED_ACCOUNTS' | ||
| response = self.session.get(url) |
There was a problem hiding this comment.
Why not:
response = self.session.get(
self.url,
params={'q': 'is:open+is:reviewer', 'o': ['MESSAGES', 'DETAILED_ACCOUNTS']})There was a problem hiding this comment.
Ah, because requests will percent-encode the : characters, and gerrit doesn't like that. :(
Aww... no. :( Time to change that pw. |
ralphbean
force-pushed
the
feature/gerrit
branch
from
0d6a9f7
to
41f8817
Compare
|
@ryneeverett, updated and rebased. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works!
I noticed while doing this that the IssueService.validate_config call is still
non-idiomatic, fwiw.