Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Querying for projects with an empty homepage shouldn't return all projects #198

Closed
ralphbean opened this issue Sep 22, 2015 · 3 comments
Closed

Querying for projects with an empty homepage shouldn't return all projects #198

ralphbean opened this issue Sep 22, 2015 · 3 comments
Labels
easyfix

Comments

@ralphbean
Copy link
Contributor

As mentioned in fedora-infra/the-new-hotness#46, when you query the anitya API for the list of projects with homepage='', it currently returns all projects (I'm assuming the homepage filter is just ignored since bool(homepage) == False).

Instead, it should return only the projects with no homepage or it should return some kind of 400 error, indicating a bad request.
@pypingou
Copy link
Member

Looking at the code, this makes me curious: https://github.com/fedora-infra/anitya/blob/master/anitya/api.py#L174

Ah no makes sense, then homepage is '' and thus it keeps going, so we need to change this check to not homepage is None.

vivekanand1101 added a commit to vivekanand1101/anitya that referenced this issue Sep 25, 2015
@vivekanand1101
Empty homepage not returning all projects
0551d03 
As suggested in issue fedora-infra#198 the check condition is changed.
@vivekanand1101 vivekanand1101 mentioned this issue Sep 25, 2015
Merged
@Akasurde
Copy link

Akasurde commented Oct 8, 2015

We can close this issue as PR is merged.

@pypingou
Copy link
Member

pypingou commented Oct 8, 2015

Indeed :)

@pypingou pypingou closed this as completed Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easyfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ralphbean @Akasurde @pypingou