Fix release-monitoring.org html scraping. #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinda ugly here, but login with release-monitoring.org broke when we added a search form to every page there. Hotness would try to scrape each page for a form, and then extract the csrf_token from that form. Except now, there are **two** forms on every page, so that scraping broke. This code updates each attempt at that to look explicitly for the form it is interested in.
|
Stupid idea: can we look for the |
Good idea! Done in 54c132d. |
|
Cool, 👍 |
ralphbean
added a commit
that referenced
this pull request
Nov 24, 2015
Fix release-monitoring.org html scraping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda ugly here, but login with release-monitoring.org broke when we
added a search form to every page there.
Hotness would try to scrape each page for a form, and then extract the
csrf_token from that form. Except now, there are two forms on every
page, so that scraping broke.
This code updates each attempt at that to look explicitly for the form
it is interested in.