Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #330 add exception #331

Closed
wants to merge 1 commit into from
Closed

Conversation

b10n1k
Copy link

@b10n1k b10n1k commented Aug 23, 2015

No description provided.

@ralphbean
Copy link
Contributor

Unless I'm mistaken, this will raise an exception every time the system comments on a bug, no matter how long it is, no?

IMHO, the logic should go:

  • Before we try to actually add the comment to bugzilla, first check the length of our comment.
  • If it is longer than that max length, then break it into multiple comments. Also log a warning with the whole comment so we can see where these ultra-long comments are coming from (that seems excessively long).

@ralphbean ralphbean closed this Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants