Add a "Releases" dropdown to the toplevel navbar. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide the data in the template for this by hanging another lazily evaluated 'reified' property to the request that returns the same data that the ``bodhi.services.releases`` cornice service does. * Fixes #350.
| @@ -78,6 +75,10 @@ def get_buildinfo(request): | |||
| return defaultdict(dict) | |||
|
|
|||
|
|
|||
| def get_releases(request): | |||
| import bodhi.services.releases | |||
| return bodhi.services.releases.query_releases_html(request)['releases'] | |||
There was a problem hiding this comment.
Doesn't this mean every time any page is rendered, it has to go through the releases cornice Service, the ListReleaseSchema, 3 different validators, and then a db query? Seems a bit heavyweight. Can't we do a simple @classmethod+ class-level-cache hack like we do with Release.get_tags? https://github.com/fedora-infra/bodhi/blob/develop/bodhi/models/models.py#L316-L330
There was a problem hiding this comment.
Yup, let's do that.
|
Pushed a commit to optimize this with a new |
ralphbean
added a commit
that referenced
this pull request
Aug 27, 2015
Add a "Releases" dropdown to the toplevel navbar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the data in the template for this by hanging another lazily
evaluated
'reified' property to the request that returns the same data that the
bodhi.services.releasescornice service does.