Fix some subtle option parsing problems: #265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_bool_option
should return the givendefault value, not
False
conf.get()
is not a fallback value but controlshow the value is parsed ([1])
"False"
is true-ish, which was causinglegacy_matching
to be true bydefault
[1] https://docs.python.org/2/library/configparser.html#ConfigParser.ConfigParser.get
In addition. the
legacy_matching
option behave erratically if the issue description contains pipes (|
). But since it seems deprecated, I don't know if it's worth fixing.