Handle a whole slough of new squirely releng messages. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They all come from this script: https://pagure.io/releng/blob/master/f/scripts/make-updates
| base = "https://dl.fedoraproject.org/pub/" + \ | ||
| "fedora/linux/development" | ||
| else: | ||
| branch = msg['msg'].get('branch', 'not-a-number') |
There was a problem hiding this comment.
No - "not-a-number", because I try to cast it to an int just two lines below.
There was a problem hiding this comment.
The not-a-number could be "rawhide", for instance. ;)
There was a problem hiding this comment.
But then msg['msg'].get('branch') would return rawhide no?
|
👍 but looks a little weak on tests, including if the branch isn't specified or is not a number |
|
As far as I can tell, that make-updates script always provides the branch and it is always a number. If it is absent or not a number, I think it will fail back to the other code paths just fine (and the other tests test those code paths). Thanks @pypingou! |
ralphbean
added a commit
that referenced
this pull request
Feb 1, 2016
Handle a whole slough of new squirely releng messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They all come from this script:
https://pagure.io/releng/blob/master/f/scripts/make-updates