This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Fix up links to bodhi and koji. #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ralphbean
commented
Nov 20, 2015
ralphbean
commented
- Fixes package versions should link to koji build #146.
- Fixes Builds list does not link to koji #93.
| href='%s/updates/%s' % (self._prod_url, nvr['nvr'])) | ||
| 'a', | ||
| c='%(version)s-%(release)s' % nvr, | ||
| href=koji_build_url % nvr) |
There was a problem hiding this comment.
for updates we point to koji and for updates-testing to bodhi?
There was a problem hiding this comment.
- for all the build nvrs, point to koji.
- if there is also an associated update, then add a
(update)link which points to bodhi.
There was a problem hiding this comment.
But here, aren't we in the updates-testing update?
There was a problem hiding this comment.
We are. But like I said, this links to the koji build directly for all build nvrs.
And then additionally, later, an extra link is tacked on to add a link to the bodhi update.
|
After some more discussion on IRC 👍 for this |
|
Thanks for wading through that with me! |
ralphbean
added a commit
that referenced
this pull request
Nov 23, 2015
Fix up links to bodhi and koji.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.