Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On update edit the "type" is lost #349

Closed
remicollet opened this issue Aug 25, 2015 · 6 comments
Closed

On update edit the "type" is lost #349

remicollet opened this issue Aug 25, 2015 · 6 comments
Labels
API Issues related to Bodhi's REST API

Comments

@remicollet
Copy link
Contributor

When "edit" a submitted update, the Type is lost, need to be check again.

Notice: the error message is not really clear: "required"
ralphbean added a commit that referenced this issue Aug 25, 2015
@ralphbean
Bugfix: keep the "type" set when editing an update.
eb98d8a 
Looks like a typo.  This should fix #349.
@ralphbean ralphbean mentioned this issue Aug 25, 2015
Closed
@ralphbean ralphbean added the API Issues related to Bodhi's REST API label Aug 25, 2015
@ralphbean
Copy link
Contributor

I'm unable to duplicate this error. @remicollet can you still get it to happen?

@lmacken
Copy link
Contributor

lmacken commented Aug 26, 2015

Which update were you dealing with when you hit this issue?

@remicollet
Copy link
Contributor Author

Yes, I can reproduce, but I think it only occurs with "new package", I cannot reproduce with standard update (bugfix or enhancement)

e.g. https://bodhi.fedoraproject.org/updates/php-zendframework-zendpdf-2.0.2-1.el6/edit

lmacken added a commit that referenced this issue Aug 26, 2015
@lmacken
tests: Write a unit test to edit the update type to try and reproduce #…
ecff6d3 
…349
@lmacken
Copy link
Contributor

lmacken commented Aug 26, 2015

Oh, I think we've discovered an inconsistency with 'new package' vs. 'newpackage' in various parts of the code. Working on a potential fix :)

@lmacken
Copy link
Contributor

lmacken commented Aug 26, 2015

Will close this once the fix is in production.

@lmacken lmacken reopened this Aug 26, 2015
@lmacken
Copy link
Contributor

lmacken commented Aug 26, 2015

Okay, this issue should hopefully be resolved.

@lmacken lmacken closed this as completed Aug 26, 2015
lmacken added a commit that referenced this issue Sep 9, 2015
@lmacken @ralphbean
tests: Write a unit test to edit the update type to try and reproduce #…
4ed1793 
…349
lmacken added a commit that referenced this issue Sep 9, 2015
@lmacken @ralphbean
Use 'newpackage' everywhere instead of 'new package' (hopefully fixes #…
392d47a 
…349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Issues related to Bodhi's REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: keep the "type" set when editing an update. fedora-infra/bodhi
3 participants
@lmacken @remicollet @ralphbean