Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid update id #329

Closed
jamesjer opened this issue Aug 22, 2015 · 2 comments · Fixed by #353
Closed

Invalid update id #329

jamesjer opened this issue Aug 22, 2015 · 2 comments · Fixed by #353
Labels
Critical We can't go on living in this sqalor, drop everything and fix it!

Comments

@jamesjer
Copy link

I just tried to create my first update with bodhi 2, for new python-gmpy2 package builds. After pressing the submit button, nothing happened for over a minute. I switched away from the browser tab to do something else. When I came back, I found a page that reads, in its entirety:

{"status": "error", "errors": [{"location": "url", "name": "id", "description": "Invalid update id"}]}

My browser says I am now on https://bodhi.fedoraproject.org/updates/undefined. Going back to the main page shows that the update was created, so apparently whatever went wrong was not fatal.
@lmacken
Copy link
Contributor

lmacken commented Aug 22, 2015

I believe this is a bug with how we handle multi-release updates (PR #304)

@lmacken lmacken added the Critical We can't go on living in this sqalor, drop everything and fix it! label Aug 22, 2015
@lmacken
Copy link
Contributor

lmacken commented Aug 22, 2015

Here are the logs for this one. What is extremely concerning to me is the fact that it takes 2 minutes to go from the first log statement to the second. I have a feeling that this slowness is coming from the code that fetches the test cases from the wiki.

2015-08-22 22:20:17,222 DEBUG [bodhi] validated = {'close_bugs': True, 'stable_karma': 3, 'csrf_token': u'c1df85ac8d1296be51991b2acf8e45e5151031b1', 'requirements': None, 'builds': [u'python-gmpy2-2.0.7-1.fc22', u'python-gmpy2-2.0.7-1.fc23'], 'autokarma': True, 'edited': '', 'suggest': <unspecified>, 'notes': u'python-gmpy2-2.0.7-1.fc22\\n\\n- math.floor(gmpy2.mpfr(\\u2018inf\\u2019)) no longer segfaults.\\n\\npython-gmpy2-2.0.7-1.fc23\\n\\n- math.floor(gmpy2.mpfr(\\u2018inf\\u2019)) no longer segfaults.', 'request': <testing>, 'bugs': [], 'unstable_karma': -3, 'require_bugs': True, 'require_testcases': True, 'type': <bugfix>, 'severity': <low>}
Adding nvr python-gmpy2-2.0.7-1.fc22
Adding nvr python-gmpy2-2.0.7-1.fc23
2015-08-22 22:22:26,532 INFO  [bodhi] Creating new update: [<Build {'override': None, 'nvr': u'python-gmpy2-2.0.7-1.fc22'}>]
2015-08-22 22:22:29,395 DEBUG [bodhi] Attempting to set request <testing>
2015-08-22 22:22:29,396 DEBUG [bodhi] Adding tag f22-updates-testing-pending to python-gmpy2-2.0.7-1.fc22
2015-08-22 22:22:31,014 DEBUG [bodhi] python-gmpy2-2.0.7-1.fc22 has been submitted for testing. 
2015-08-22 22:22:50,000 DEBUG [bodhi] fedmsg sending u'update.request.testing'
2015-08-22 22:22:53,192 DEBUG [bodhi] Setting alias for python-gmpy2-2.0.7-1.fc22 to FEDORA-2015-14000
2015-08-22 22:22:53,197 DEBUG [bodhi] update = <Update {'close_bugs': True, 'old_updateid': None, 'pushed': False, 'require_testcases': True, 'critpath': False, 'date_approved': None, 'stable_karma': 3, 'date_pushed': None, 'requirements': '', 'severity': u'low', 'title': u'python-gmpy2-2.0.7-1.fc22', 'suggest': u'unspecified', 'require_bugs': True, 'comments': [{'bug_feedback': [], 'user_id': 91, 'text': u'This update has been submitted for testing by jjames. ', 'testcase_feedback': [], 'karma_critpath': 0, 'update': 37281, 'update_id': 37281, 'karma': 0, 'anonymous': False, 'timestamp': '2015-08-22 22:22:31', 'id': 314019, 'user': {'stacks': [], 'buildroot_overrides': [], 'name': u'bodhi', 'avatar': None}}], 'updateid': u'FEDORA-2015-14000', 'cves': [], 'type': u'bugfix', 'status': u'pending', 'date_submitted': '2015-08-22 22:22:31', 'unstable_karma': -3, 'submitter': u'jjames', 'user': {'stacks': [], 'buildroot_overrides': [], 'name': u'jjames', 'avatar': None}, 'locked': False, 'builds': [{'override': None, 'nvr': u'python-gmpy2-2.0.7-1.fc22'}], 'date_modified': None, 'test_cases': [], 'notes': u'python-gmpy2-2.0.7-1.fc22\\n\\n- math.floor(gmpy2.mpfr(\\u2018inf\\u2019)) no longer segfaults.\\n\\npython-gmpy2-2.0.7-1.fc23\\n\\n- math.floor(gmpy2.mpfr(\\u2018inf\\u2019)) no longer segfaults.', 'request': u'testing', 'bugs': [], 'alias': u'FEDORA-2015-14000', 'karma': 0, 'release': {'dist_tag': u'f22', 'name': u'F22', 'testing_tag': u'f22-updates-testing', 'pending_stable_tag': u'f22-updates-pending', 'long_name': u'Fedora 22', 'state': u'current', 'version': u'22', 'override_tag': u'f22-override', 'branch': u'f22', 'id_prefix': u'FEDORA', 'pending_testing_tag': u'f22-updates-testing-pending', 'stable_tag': u'f22-updates', 'candidate_tag': u'f22-updates-candidate'}}>
2015-08-22 22:22:53,202 INFO  [bodhi] Creating new update: [<Build {'override': None, 'nvr': u'python-gmpy2-2.0.7-1.fc23'}>]
2015-08-22 22:22:55,922 DEBUG [bodhi] Attempting to set request <testing>
2015-08-22 22:22:55,923 DEBUG [bodhi] Adding tag f23-updates-testing-pending to python-gmpy2-2.0.7-1.fc23
2015-08-22 22:22:57,520 DEBUG [bodhi] python-gmpy2-2.0.7-1.fc23 has been submitted for testing. 
2015-08-22 22:22:59,293 DEBUG [bodhi] fedmsg sending u'update.request.testing'
2015-08-22 22:23:03,391 DEBUG [bodhi] Setting alias for python-gmpy2-2.0.7-1.fc23 to FEDORA-2015-14001
2015-08-22 22:23:03,396 DEBUG [bodhi] update = <Update {'close_bugs': True, 'old_updateid': None, 'pushed': False, 'require_testcases': True, 'critpath': False, 'date_approved': None, 'stable_karma': 3, 'date_pushed': None, 'requirements': '', 'severity': u'low', 'title': u'python-gmpy2-2.0.7-1.fc23', 'suggest': u'unspecified', 'require_bugs': True, 'comments': [{'bug_feedback': [], 'user_id': 91, 'text': u'This update has been submitted for testing by jjames. ', 'testcase_feedback': [], 'karma_critpath': 0, 'update': 37282, 'update_id': 37282, 'karma': 0, 'anonymous': False, 'timestamp': '2015-08-22 22:22:57', 'id': 314020, 'user': {'stacks': [], 'buildroot_overrides': [], 'name': u'bodhi', 'avatar': None}}], 'updateid': u'FEDORA-2015-14001', 'cves': [], 'type': u'bugfix', 'status': u'pending', 'date_submitted': '2015-08-22 22:22:57', 'unstable_karma': -3, 'submitter': u'jjames', 'user': {'stacks': [], 'buildroot_overrides': [], 'name': u'jjames', 'avatar': None}, 'locked': False, 'builds': [{'override': None, 'nvr': u'python-gmpy2-2.0.7-1.fc23'}], 'date_modified': None, 'test_cases': [], 'notes': u'python-gmpy2-2.0.7-1.fc22\\n\\n- math.floor(gmpy2.mpfr(\\u2018inf\\u2019)) no longer segfaults.\\n\\npython-gmpy2-2.0.7-1.fc23\\n\\n- math.floor(gmpy2.mpfr(\\u2018inf\\u2019)) no longer segfaults.', 'request': u'testing', 'bugs': [], 'alias': u'FEDORA-2

ralphbean added a commit that referenced this issue Aug 25, 2015
@ralphbean
Bugfix when redirecting after multi-release update creation.
4d0ed16 
This fixes a bug introduced in #304.

When you do multi-release updates, the JSON response that comes back contains
all the created updates in a list.

* Fixes #352.
* Fixes #329.
@ralphbean ralphbean mentioned this issue Aug 25, 2015
Merged
ralphbean added a commit that referenced this issue Sep 9, 2015
@ralphbean
Bugfix when redirecting after multi-release update creation.
a85a22e 
This fixes a bug introduced in #304.

When you do multi-release updates, the JSON response that comes back contains
all the created updates in a list.

* Fixes #352.
* Fixes #329.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Critical We can't go on living in this sqalor, drop everything and fix it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix when redirecting after multi-release update creation. fedora-infra/bodhi
2 participants
@lmacken @jamesjer