Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: keep the "type" set when editing an update. #354

Closed
wants to merge 2 commits into from

Conversation

ralphbean
Copy link
Contributor

Looks like a typo. This should fix #349.

Looks like a typo.  This should fix #349.
@pypingou
Copy link
Member

Looks safe to me (but I don't know bodhi's sources that well)

@ralphbean
Copy link
Contributor Author

That type is an instance of the UpdateType object which gets its behavior from this class.

@ralphbean
Copy link
Contributor Author

On the other hand, now that I look more closely, this may not actually fix the bug:

>>> bodhi.models.UpdateType().security.description
'security'
>>> bodhi.models.UpdateType().security.value
'security'

@ralphbean
Copy link
Contributor Author

OK, it works locally with this.

@pypingou
Copy link
Member

Still ok for me (with the same limitation as before)

@lmacken
Copy link
Contributor

lmacken commented Aug 25, 2015

Hmm, I don't see how this changes anything. description and value are the same, and we use description all over the place still...

@ralphbean ralphbean closed this Aug 26, 2015
@bowlofeggs bowlofeggs deleted the feature/retain-type branch May 24, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On update edit the "type" is lost
3 participants