This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Fix PEP8 compliance and remove unused imports #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| utils.FASCLIENT.base_url = arg.fasurl | ||
| utils.FASCLIENT.insecure = arg.insecure | ||
| pkgdb2client.utils.FASCLIENT.base_url = arg.fasurl | ||
| pkgdb2client.utils.FASCLIENT.insecure = arg.insecure |
There was a problem hiding this comment.
These are not necessarily needed: https://github.com/tyll/packagedb-cli/blob/cleanup/pkgdb2client/admin.py#L26
There was a problem hiding this comment.
The change is for the cli.py file, that does not import as utils: https://github.com/fedora-infra/packagedb-cli/blob/master/pkgdb2client/cli.py#L28
Also the pkgdb2client. prefix is also used in other lines already: https://github.com/fedora-infra/packagedb-cli/blob/master/pkgdb2client/cli.py#L435
There was a problem hiding this comment.
but we're in the admin.py file here no?
NM: I either need glasses or sleep :)
pypingou
added a commit
that referenced
this pull request
Nov 17, 2015
Fix PEP8 compliance and remove unused imports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.