Complain when users specify old config values. #307
Conversation
In 81e8d74, we accidentally changed the config value from ``only_if_assigned`` to ``$SERVICE.only_if_assigned``. That's okay by me, just because it makes things consistent. But, it breaks people's existing configs (it broke mine). This change adds some warnings which will halt bugwarrior and prompt you to update your config.
Isn't the current consistency that Common Service Configuration Options do not have the If we wanted to eliminate this distinction, I would think we'd want to go in the opposite direction -- removing the |
|
The |
|
From a quick search, my understanding is that if a key isn't found in a given section, it will fall back to the one found in If that is correct, then I agree that putting service-specific values in their own namespace makes sense. We don't want to make falling back to a nonsensical default value a possibility. Because nobody reuses their usernames and passwords, right? Err, bad example. And since Does that make sense? |
|
Ahh, sure, that does make sense! |
|
Cool. LGTM. |
|
OK. Will merge this soon. |
In 81e8d74, we accidentally changed the config value from
only_if_assignedto$SERVICE.only_if_assigned. That's okay by me,just because it makes things consistent. But, it breaks people's existing
configs (it broke mine).
This change adds some warnings which will halt bugwarrior and prompt you to
update your config.