Spec URL: http://ralph.fedorapeople.org//pag.spec SRPM URL: http://ralph.fedorapeople.org//pag-0.3-1.fc23.src.rpm Description: Command line tool for interacting with https://pagure.io
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13597632
AFAIK it should be named as python-pag.
(In reply to Igor Gnatenko from comment #2) > AFAIK it should be named as python-pag. That depends on whether the "package is usable on its own" [https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28General.29]. Since it's a commandline client, I'd say yes. So the name seems OK. A related question is whether the module can be useful on it's own, from other python code? %description should say a bit more, not everybody known what pagure is and kind of interaction you can have with it: """ pag is a command line tool for interacting with the git repository hosting service https://pagure.io. It provides the support for cloning projects and opening new ones. """ Also the description should end with a dot. License doesn't match the info on pypi. And the license field doesn't match the categories ;(
def run(cmd): click.echo(' $ ' + cmd) return os.system(cmd) def clone(name): url = repo_url(name, ssh=True, git=True) run('git clone %s %s' % (url, name.split('/')[-1])) That's ... ugly. Since this is python3 only, why not use subprocess.run?
Ah, I didn't know about `subprocess.run`. Seems nice! https://pagure.io/pag/issue/1
Here's quick release that fixes just the license and description issues: Spec URL: http://threebean.org/rpm/SPECS/pag.spec SRPM URL: http://threebean.org/rpm/SRPMS/pag-0.4-1.fc23.src.rpm
To answer the question about naming: it seems that pag is just a CLI, at least for now, and other project will not be using the python module. If that ever changes, it is always possible to split out python3-pag and even possibly python2-pag submodules. So the name 'pag' is appropriate. I don't think you need this part: sed -i 's|/usr/bin/python$|/usr/bin/python3|' %{buildroot}/%{_bindir}/pag setuptools seems to set the header properly on its own. + latest version + package name is OK + license is acceptable (GPLv3+) + license file is present, %license is used + python packaging macros are used + no scriptlets present or necessary Package is APPROVED.
pag-0.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-661496dd88
pag-0.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1946c7c76
pag-0.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-661496dd88
pag-0.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e1946c7c76
pag-0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
pag-0.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.