Make the anitya_cron multithreaded and drop support for the progress-bar #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this version, using 10 threads running the cron drops from 90minutes to less than 10 minutes.
| PBAR = False | ||
| def update_project(project): | ||
| """ Check for updates on the specified project. """ | ||
| print(project.name) |
There was a problem hiding this comment.
You always run as python3? or is there a from __future__ import print_function here that I'm missing.
There was a problem hiding this comment.
it seems that print() works fine in python 2.7 without the import of __future__ (tested on pkgdb02 with python 2.7.5).
That being said, it should be a call to the logger anyway :)
|
👍 as-is, with two non-blocking questions above. |
pypingou
added a commit
that referenced
this pull request
Jun 28, 2015
Make the anitya_cron multithreaded and drop support for the progress-bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this version, using 10 threads running the cron drops from 90minutes
to less than 10 minutes.