Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown unordered lists do not work in update notes #265

Closed
robert-scheck opened this issue Aug 20, 2015 · 7 comments
Closed

Markdown unordered lists do not work in update notes #265

robert-scheck opened this issue Aug 20, 2015 · 7 comments
Labels
CSS Issues related to Bodhi's Content Style Sheets EasyFix These are good issues to get started with if you are new to the project

Comments

@robert-scheck
Copy link
Contributor

Filling the update notes under https://bodhi.fedoraproject.org/updates/new with unordered lists in markdown syntax (https://help.github.com/articles/markdown-basics/) does not work, neither in the preview nor after submitting, visit e.g. https://bodhi.fedoraproject.org/updates/phpMyAdmin-4.4.14-1.fc23 with Firefox 38 ESR from RHEL/CentOS 6. It seems to work properly with a text browser such as w3m (CSS issue?).

@ralphbean
Copy link
Contributor

They do work, it just requires that you put an extra newline in front of the list like this:

  • this
  • is
  • a
  • list

@robert-scheck
Copy link
Contributor Author

No, they do not work. And this seems to be a CSS issue.

@ralphbean
Copy link
Contributor

I just tested with a comment on that update. To be clear, you have to put an extra newline before the list, like this:

Some paragraph text goes here

* this
* is
* a
* list

@robert-scheck
Copy link
Contributor Author

unordered-lists

@ralphbean
Copy link
Contributor

Oh, you want the bullets to show up?

@robert-scheck
Copy link
Contributor Author

Yes, well, would be nice. This why I assumed a CSS issue (last sentence of my initial description) ;-)

@ralphbean ralphbean reopened this Aug 20, 2015
@ralphbean ralphbean added CSS Issues related to Bodhi's Content Style Sheets EasyFix These are good issues to get started with if you are new to the project labels Aug 21, 2015
@ralphbean
Copy link
Contributor

Noting here that we'll need to surround each markdown area with a <span class="markdown">...</span> tag so that we can zero-in the CSS rules with something like:

.markdown {
   list-style-type: cjk-ideographic;
}

ralphbean added a commit that referenced this issue Aug 28, 2015
* First, we extend the fedora-flavored markdown hack to add a "surround"
  postprocessor that wraps all markdown returned from our API endpoint with
  ``<div class="markdown">...</div>``.
* Second, we use that new marker to apply list decoration to lists inside that
  container.

Fixes #265.
ralphbean added a commit that referenced this issue Sep 9, 2015
* First, we extend the fedora-flavored markdown hack to add a "surround"
  postprocessor that wraps all markdown returned from our API endpoint with
  ``<div class="markdown">...</div>``.
* Second, we use that new marker to apply list decoration to lists inside that
  container.

Fixes #265.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Issues related to Bodhi's Content Style Sheets EasyFix These are good issues to get started with if you are new to the project
Projects
None yet
Development

No branches or pull requests

3 participants