New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test IssueService.issues() #294
Merged
ryneeverett
merged 17 commits into
GothenburgBitFactory:develop
from
ryneeverett:responses-tests
May 10, 2016
Merged
Test IssueService.issues() #294
ryneeverett
merged 17 commits into
GothenburgBitFactory:develop
from
ryneeverett:responses-tests
May 10, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
changed the title
Responses (Mock Requests) Tests[WIP]
[WIP] Responses (Mock Requests) Tests
Mar 25, 2016
ryneeverett
force-pushed
the
responses-tests
branch
3 times, most recently
from
March 27, 2016 02:38
8428a9a
to
8d6bce3
Compare
ryneeverett
changed the title
[WIP] Responses (Mock Requests) Tests
[WIP] Test IssueService.issues()
Mar 31, 2016
ryneeverett
force-pushed
the
responses-tests
branch
2 times, most recently
from
March 31, 2016 03:04
3d42857
to
9a1cad7
Compare
ryneeverett
force-pushed
the
responses-tests
branch
2 times, most recently
from
April 19, 2016 04:14
ad442c5
to
6ed8a22
Compare
ryneeverett
force-pushed
the
responses-tests
branch
from
April 22, 2016 13:17
6ed8a22
to
3868757
Compare
With responses as a test dependency we can test methods that make requests without hitting remote API's. This should help a lot with the test coverage of service modules.
- self.target is referenced in ActiveCollab2Client but undefined. - "ticket" is not a valid type to pass to get_default_description
ryneeverett
force-pushed
the
responses-tests
branch
from
April 30, 2016 17:53
d290c09
to
b222c99
Compare
This is more readable, yields more readable errors, and ensures that keys aren't missed.
ServiceClient.json_response's signature takes a url parameter as well.
This ensures that certain test methods are implemented for each service. In addition, it provides a reasonable place to document each test.
This makes the test_issues methods a bit easier to read.
ryneeverett
force-pushed
the
responses-tests
branch
2 times, most recently
from
May 7, 2016 00:35
58ed0ad
to
52c3ca2
Compare
ryneeverett
changed the title
[WIP] Test IssueService.issues()
Test IssueService.issues()
May 7, 2016
Alright, I think this is ready to go. |
This is awesome. Thanks so much @ryneeverett! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services
Notes