Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test IssueService.issues() #294

Merged
merged 17 commits into from May 10, 2016

Conversation

ryneeverett
Copy link
Collaborator

@ryneeverett ryneeverett commented Mar 25, 2016

Services

  • activecollab
  • activecollab2
  • bitbucket
  • bugzilla
  • gerrit
  • github
  • gitlab
  • jira
  • megaplan
  • redmine
  • taiga
  • teamlab
  • trac

Notes

@ryneeverett ryneeverett changed the title Responses (Mock Requests) Tests[WIP] [WIP] Responses (Mock Requests) Tests Mar 25, 2016
@ryneeverett ryneeverett force-pushed the responses-tests branch 3 times, most recently from 8428a9a to 8d6bce3 Compare March 27, 2016 02:38
@ryneeverett ryneeverett changed the title [WIP] Responses (Mock Requests) Tests [WIP] Test IssueService.issues() Mar 31, 2016
@ryneeverett ryneeverett force-pushed the responses-tests branch 2 times, most recently from 3d42857 to 9a1cad7 Compare March 31, 2016 03:04
@ryneeverett ryneeverett force-pushed the responses-tests branch 2 times, most recently from ad442c5 to 6ed8a22 Compare April 19, 2016 04:14
With responses as a test dependency we can test methods that make
requests without hitting remote API's. This should help a lot with the
test coverage of service modules.
- self.target is referenced in ActiveCollab2Client but undefined.
- "ticket" is not a valid type to pass to get_default_description
This is more readable, yields more readable errors, and ensures that
keys aren't missed.
ServiceClient.json_response's signature takes a url parameter as well.
This ensures that certain test methods are implemented for each service.
In addition, it provides a reasonable place to document each test.
This makes the test_issues methods a bit easier to read.
@ryneeverett ryneeverett force-pushed the responses-tests branch 2 times, most recently from 58ed0ad to 52c3ca2 Compare May 7, 2016 00:35
@ryneeverett ryneeverett changed the title [WIP] Test IssueService.issues() Test IssueService.issues() May 7, 2016
@ryneeverett
Copy link
Collaborator Author

Alright, I think this is ready to go.

@ralphbean
Copy link
Sponsor Collaborator

This is awesome. Thanks so much @ryneeverett!

@ryneeverett ryneeverett merged commit 02db176 into GothenburgBitFactory:develop May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants