Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Add a bodhi-approve-testing script (fixes #298) #639

Merged
merged 3 commits into from Oct 7, 2015

Conversation

lmacken
Copy link
Contributor

@lmacken lmacken commented Oct 6, 2015

fixes #298

@ralphbean
Copy link
Contributor

👍 as is

Some thoughts though:

  • It is confusing that we have both meets_testing_requirements and met_testing_requirements and that they don't share code. I think met does the same things as meets except it tests for a comment also. Perhaps met could be refactored to call meets first, and then check for the comment?
  • It would be nice to add a test that has an update the meets but hasn't yet met. Assert those things are true and false respectively. Add the comment. Then finally assert that both are true afterwards.

@lmacken
Copy link
Contributor Author

lmacken commented Oct 6, 2015

Okay, I think I addressed both of your concerns?

@ralphbean
Copy link
Contributor

👍

@lmacken
Copy link
Contributor Author

lmacken commented Oct 7, 2015

Thanks :)

lmacken added a commit that referenced this pull request Oct 7, 2015
scripts: Add a bodhi-approve-testing script (fixes #298)
@lmacken lmacken merged commit 7c6eeec into develop Oct 7, 2015
@lmacken lmacken deleted the feature/approve-testing branch October 7, 2015 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement nagmail script
2 participants