Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not add anitya project. Not logged in. #56

Closed
pnemade opened this issue Aug 27, 2015 · 15 comments
Closed

Could not add anitya project. Not logged in. #56

pnemade opened this issue Aug 27, 2015 · 15 comments

Comments

@pnemade
Copy link

pnemade commented Aug 27, 2015

I am seeing this kind of message for many other projects but could not understand why its coming besides some users saying they are already logged into Anitya.

https://apps.fedoraproject.org/datagrepper/raw?topic=org.fedoraproject.prod.hotness.project.map

Can someone help to understand this?

@tomhughes
Copy link

I just got this for libosmium. At 1214 UTC I got this:

A new version of "libosmium" has been detected:  "v2.4.0" newer than "v2.3.0", packaged as "libosmium"
    https://release-monitoring.org/project/7023/

but no bug was filed despite "bugs and builds" being set at https://admin.fedoraproject.org/pkgdb/package/libosmium/ so I tried turned that off and on again to force a new check and then at 1518 UTC I got this:

hotness tried to map libosmium to an upstream project, but failed:  "Could not add anitya project.  Not logged in."
    https://release-monitoring.org/project/7023/

@pnemade
Copy link
Author

pnemade commented Aug 29, 2015

Please someone from developers reply. I think this is happening since last 3 weeks now.
@ralphbean can you help here?

@ralphbean
Copy link
Contributor

Sorry, been busy with bodhi2 here. I think it has a session with anitya that just expires. Some logic will need to be added that tells it how to log back in when that happens. Let me restart it and see if that fixes it (short term).

@ralphbean
Copy link
Contributor

Well, I tried that and then tried toggling the monitor flag on libosmium again, but it didn't work: https://apps.fedoraproject.org/datagrepper/raw?package=libosmium

hotness still thinks that it isn't logged in, so, something else must be up.

@ralphbean
Copy link
Contributor

Can duplicate the login failure using the hotness.anitya module on my laptop.

@ralphbean
Copy link
Contributor

Using this to test, if anyone else wants to mess with it in the meantime:

import hotness.anitya

client = hotness.anitya.Anitya()
client.login("YOUR_USERNAME", "YOUR_PASSWORD")
print client.is_logged_in

@ralphbean
Copy link
Contributor

@puiterwijk, @pypingou, do either of you have any ideas on this one? I'm stuck for the moment.

@tomhughes
Copy link

It seems that when login follows the redirect back from id.fedoraproject.org to release-monitoring.org the arguments it passes are not enough to convince release-monitoring.org that we are no logged in.

@puiterwijk
Copy link
Contributor

I have patches for both sides of the story, sending them in

puiterwijk added a commit that referenced this issue Sep 1, 2015
The /login/fedora link may always just redirect the user silently.

Helps with #56, other part of the fix is in anitya.

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
puiterwijk added a commit to fedora-infra/anitya that referenced this issue Sep 1, 2015
The OpenID provider may always decide to use a POST form
instead of a redirect with all the data.

Helps with fedora-infra/the-new-hotness#56

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
puiterwijk added a commit to fedora-infra/anitya that referenced this issue Sep 1, 2015
The OpenID provider may always decide to use a POST form
instead of a redirect with all the data.

Helps with fedora-infra/the-new-hotness#56

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
@puiterwijk
Copy link
Contributor

Note: this probably broke right after we moved to Ipsilon in Fedora Infrastructure, as that should always decide to use POST responses in Fedora Infra.

@puiterwijk
Copy link
Contributor

Note2: the previous statement is NOT a promise, Ipsilon might still send a redirect reply in some cases, but the chance of it using POST is higher in Fedora Infra.
When implementing OpenID, expect either, do not assume one or the other!

@pypingou
Copy link
Member

pypingou commented Sep 1, 2015

New anitya released and pushed to prod with @puiterwijk 's patch

@pypingou
Copy link
Member

pypingou commented Sep 1, 2015

>>> print client.is_logged_in
True

With @puiterwijk 's patch applied to the-new-hotness (doesn't work otherwise)

@ralphbean
Copy link
Contributor

I'm glad I asked :whew:

@tomhughes
Copy link

Although this is no longer erroring, it still doesn't seem to be showing any inclination to actually open a bug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants