Service Client Base Class #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryneeverett
force-pushed
the
service-client-base
branch
from
ed44c71
to
8fbb174
Compare
|
👍 to the Let's wait to see if we get a response on #299. |
ryneeverett
force-pushed
the
service-client-base
branch
2 times, most recently
from
ecfa8ba
to
4a42012
Compare
|
Rebased and should be ready to go. @ralphbean I used the |
This seems to be the direction the abstraction is going in and facilitates DRYing up the json response handling.
|
Yeah, that's fine. Thanks @ryneeverett! Good to merge here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the direction the abstraction is going in and facilitates DRYing up the json response handling.