Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A service for pulling issues from a taiga instance. #301

Merged
merged 5 commits into from Apr 13, 2016
Merged

Conversation

ralphbean
Copy link
Sponsor Collaborator

It works! Any feedback?

def __init__(self, *args, **kw):
super(TaigaService, self).__init__(*args, **kw)
self.url = self.config_get('base_uri')
self.auth_token = self.config_get_password('auth_token', 'nousername')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better make login an optional argument in the IssueService class? E.g.:

    def config_get_password(self, key, login='nousername')

Copy link
Sponsor Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely, yes. Let's do that. :)

@ryneeverett
Copy link
Collaborator

Could you add a test module with at least the test_to_taskwarrior test case?

@ryneeverett
Copy link
Collaborator

Looks good. My only reservation is the lack of a test_to_taskwarrior test case.

@ralphbean
Copy link
Sponsor Collaborator Author

My only reservation is the lack of a test_to_taskwarrior test case.

Agreed. I finally got time to do it. Should be all finished up now.

@ryneeverett
Copy link
Collaborator

LGTM

@ralphbean ralphbean merged commit 39f949d into develop Apr 13, 2016
@ralphbean ralphbean deleted the feature/taiga branch April 13, 2016 20:07
@ralphbean
Copy link
Sponsor Collaborator Author

Thanks @ryneeverett!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants