New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A service for pulling issues from a taiga instance. #301
Conversation
638a5a4
to
fd66b5d
Compare
def __init__(self, *args, **kw): | ||
super(TaigaService, self).__init__(*args, **kw) | ||
self.url = self.config_get('base_uri') | ||
self.auth_token = self.config_get_password('auth_token', 'nousername') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better make login
an optional argument in the IssueService
class? E.g.:
def config_get_password(self, key, login='nousername')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely, yes. Let's do that. :)
Could you add a test module with at least the |
Looks good. My only reservation is the lack of a |
Agreed. I finally got time to do it. Should be all finished up now. |
LGTM |
Thanks @ryneeverett! |
It works! Any feedback?