Change the mouse cursor when doing an action #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently after pressing the button to make an update go to testing/stable the bodhi logo (the cabbage) starts spinning. This is really nice but easy to miss. With this change the mouse cursor will also change, making it clearer that something is going on. Fixes #355
|
It doesn't seem to work here. Other interactions on the page are overriding the cursor setting. |
Setting the button to disabled would override the cursor setting. By switching the order, this should get it working.
|
OK, that gets it working locally. |
|
👍 for me |
|
Sweet, 👍 |
lmacken
added a commit
that referenced
this pull request
Aug 25, 2015
Change the mouse cursor when doing an action
|
This feature doesn't work for me :( |
|
What browser, @lmacken? Firefox? |
|
Just tested and it works in both Firefox and Chrome here. Try to hard-reload the page to get the latest CSS assets? |
ralphbean
added a commit
that referenced
this pull request
Sep 11, 2015
Fixes #356. Before this change, they were ``<PREFIX>-<YEAR>-<INTEGER>``, where the last part grows monotonically with each new update. This commit changes that to ``<PREFIX>-<YEAR>-<HASH>``, where hash is the first 10 characters of a hash of a random uuid. The problem with the way things are now is that: - we have a race condition. If you try to submit two updates at the same time (via a script, this is easy to do), then they both go into the code where their alias is assigned at the same time, they both get the same integer, and then when they try to commit their database transactions, one wins and the other fails. - the alias-assigning code is one of the slower parts of the new update process. It takes 1-2s iirc (because it has to query for the latest update before it and figure out its id). The downside here is that the update aliases will no longer be meaningful like they were. You won't be able to look at the latest one and instantly know how many updates there have been so far in 2015, for instance. IMHO, this isn't worth the trouble they're causing us. Up for discussion!
ralphbean
added a commit
that referenced
this pull request
Sep 11, 2015
Fixes #356. Before this change, they were ``<PREFIX>-<YEAR>-<INTEGER>``, where the last part grows monotonically with each new update. This commit changes that to ``<PREFIX>-<YEAR>-<HASH>``, where hash is the first 10 characters of a hash of a random uuid. The problem with the way things are now is that: - we have a race condition. If you try to submit two updates at the same time (via a script, this is easy to do), then they both go into the code where their alias is assigned at the same time, they both get the same integer, and then when they try to commit their database transactions, one wins and the other fails. - the alias-assigning code is one of the slower parts of the new update process. It takes 1-2s iirc (because it has to query for the latest update before it and figure out its id). The downside here is that the update aliases will no longer be meaningful like they were. You won't be able to look at the latest one and instantly know how many updates there have been so far in 2015, for instance. IMHO, this isn't worth the trouble they're causing us. Up for discussion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently after pressing the button to make an update go to testing/stable
the bodhi logo (the cabbage) starts spinning.
This is really nice but easy to miss.
With this change the mouse cursor will also change, making it clearer that
something is going on.
Fixes #355