Rely on the closed_at field rather than the updated_on one
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a closed PR, these two should be the same but while we are sure `closed_at` won't change, we can't ensure at 100% the same for `updated_on` so by relying on `closed_at` we are safer.
ralphbean
added a commit
that referenced
this pull request
Oct 5, 2015
Rely on the `closed_at` field rather than the `updated_on` one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a closed PR, these two should be the same but while we are sure
closed_atwon't change, we can't ensure at 100% the same forupdated_onso by relying on
closed_atwe are safer.