We would run this with cron now, right?

Yeah, similar to bodhi/scripts/expire_overrides.py

+1 for nagmails

Freeze should lift on Tuesday, so we'll get another shot at this after that.

Untested, but does this look good for our bodhi2/backend/tasks/main.yml ansible role?

- name: bodhi-approve-testing cron job.                                         
  cron: name="bodhi-approve-testing" hour="*/6" user="masher"                   
        job="/usr/bin/bodhi-approve-testing /etc/bodhi/production.ini"                   
        cron_file=bodhi-approve-testing-job                                     
  when: inventory_hostname.startswith('bodhi-backend02') and env == "production"
  tags:                                                                         
  - config                                                                      
  - bodhi                                                                       
  - cron                                                                        

Unfortunately, no. It would work(!) but we've been trying to avoid using the ansible cron module only because it installs stuff in a weird way that is hard to uncover when you're logged in and looking at the box.

We try to instead copy an appropriately named cron file to /etc/cron.d/. Check the badges/backend role where we copy the scripts first and then copy the cron definitions next for an example.

I was missing this feature since new bodhi was introduced. Thanks for solving this "regression".

Discussing this with @ralphbean on IRC, his concern was that things get installed outside of /etc/cron.d, however with my patch the ansible cron_file actually does that for us, so he agreed that it is fine.

This cron job has been deployed to bodhi-backend02.

Is this actually working? I'm still not getting reminder emails when my updates can be pushed to stable.

I see the comments getting added to the updates, but I'm not getting any email notifications of them

Yes, I see the same thing, Orion. I don't seem to have permission to re-open this ticket, though.

@lmacken Can you reopen this issue? It seems that the notifications are not being delivered.

I received email notification:

The following comment has been added to the ruby-2.2.4-47.fc22 update:

bodhi - 2016-01-07 00:00:12.508018 (karma: 0)
This update has reached 7 days in testing and can be pushed to stable now if the maintainer wishes

To reply to this comment, please visit the URL at the bottom of this mail

for my update [1] today. So it seems it works now.

[1] https://bodhi.fedoraproject.org/updates/FEDORA-2015-c4409eb73a

You are right - I got one of those emails this morning too. Yay for being bugged about updates again. :-)

Agreed, it seems to work for me now too so even though I just asked to reopen, we can close again ☺

👍

Started to work for me as of 30 Dec 2015, thanks.