Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't comment on or modify Security Response bugs for updates in testing #389

Merged
merged 4 commits into from Aug 26, 2015

Conversation

lmacken
Copy link
Contributor

@lmacken lmacken commented Aug 26, 2015

This resolves part of issue #368

@ralphbean
Copy link
Contributor

Looks reasonable for now, but I like the more explicit logic in the bodhi1 code that checks if self.type is UpdateType.security first.

@lmacken
Copy link
Contributor Author

lmacken commented Aug 26, 2015

Updated to address your concern, as well as thoger's request to not bother ever closing parent bugs.

@ralphbean
Copy link
Contributor

LGTM!

@lmacken
Copy link
Contributor Author

lmacken commented Aug 26, 2015

A couple more changes to review plz ;)

@ralphbean
Copy link
Contributor

Nice, 746f686 looks good.

lmacken added a commit that referenced this pull request Aug 26, 2015
Don't comment on or modify Security Response bugs for updates in testing
@lmacken lmacken merged commit 72cb815 into develop Aug 26, 2015
@lmacken lmacken deleted the feature/sec-resp-bugs branch August 26, 2015 23:06
@lmacken
Copy link
Contributor Author

lmacken commented Aug 26, 2015

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants