Mark these pkgdb examples as Legacy #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs scrutiny from @pypingou and @tyll. By marking these tests as ``Legacy``, they will no longer show up in the docs at http://fedora-fedmsg.readthedocs.org/en/latest/topics.html In fedora-infra/fedmsg#255, @tyll mentioned that some pkgdb1 messages still appeared in the docs even though they are not being broadcast anymore. I did my best to check that the topics of these messages that I've marked do not actually appear in the pkgdb2 source, but I'd be much more comfortable merging this if someone more familiar with the source could look over them. If merged, this fixes fedora-infra/fedmsg#255.
| @@ -1241,7 +1241,7 @@ class TestPkgdbDeleteAcl(Base): | |||
| } | |||
|
|
|||
|
|
|||
| class TestPkgdbBranchRequest(Base): | |||
| class LegacyTestPkgdbBranchRequest(Base): | |||
There was a problem hiding this comment.
This one is needed by the admin_action branch, you just have code here that's not yet live :) (for once ^^)
|
I'll have to check for the first two, the last two are definitevely of interest. |
As discussed in #146, they correspond to messages that are a part of the pkgdb ``admin_action`` branch.
| @@ -443,7 +443,7 @@ class TestLegacyPkgdbPackageRetire(Base): | |||
| } | |||
|
|
|||
|
|
|||
| class TestPkgdbUserRemove(Base): | |||
| class LegacyTestPkgdbUserRemove(Base): | |||
There was a problem hiding this comment.
Using git grep -i remove I see nothing involving fedmsg, so that one is safe for sure
|
👍 for me, looks safe |
ralphbean
added a commit
that referenced
this pull request
Sep 22, 2014
Mark these pkgdb examples as Legacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs scrutiny from @pypingou and @tyll.
By marking these tests as
Legacy, they will no longer show up in thedocs at http://fedora-fedmsg.readthedocs.org/en/latest/topics.html
In fedora-infra/fedmsg#255, @tyll mentioned that some pkgdb1 messages
still appeared in the docs even though they are not being broadcast
anymore. I did my best to check that the topics of these messages that
I've marked do not actually appear in the pkgdb2 source, but I'd be much
more comfortable merging this if someone more familiar with the source
could look over them.
If merged, this fixes fedora-infra/fedmsg#255.