Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog entry for scratch build is useless #19

Closed
voxik opened this issue Feb 23, 2015 · 2 comments
Closed

Changelog entry for scratch build is useless #19

voxik opened this issue Feb 23, 2015 · 2 comments

Comments

@voxik
Copy link
Contributor

voxik commented Feb 23, 2015

It would be nice if the scratch build can contain some more useful entry. You can compare the-new-hotness changelog entry with previous entries for rubygem-jbuilder build for example [1].

Not mentioning that the formatting with quotes etc is suboptimal.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1154598#c6
@ralphbean
Copy link
Contributor

Can you explain more? Give an example of what you think the changelog should be?

@voxik
Copy link
Contributor Author

voxik commented Feb 23, 2015

Sure, you can compare these two entries:

* Sun Feb 22 2015 "Fedora Release Monitoring <release-monitoring@fedoraproject.org>" - 2.2.8-1
- "Latest upstream, 2.2.8 for ##1154598 NEW        - jstribny@redhat.com -
  rubygem-jbuilder-2.2.7 is available"

* Tue Oct 14 2014 Josef Stribny <jstribny@redhat.com> - 2.2.2-1
- Update to 2.2.2

It would be cool if I can just download the srpm, do "fedpkg import" and build. Since the changelog contains "release-monitoring@fedoraproject.org", I will need to change it. The actual descipriton makes no sense to me at all, while the something like "Update to jbuilder 2.2.8." would be quite acceptable.

ralphbean added a commit that referenced this issue Feb 24, 2015
@ralphbean
Generate a nicer changelog for the scratch task srpm.
97b865e 
This should fix #19.
@ralphbean ralphbean mentioned this issue Feb 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@voxik @ralphbean