Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give fedmsg-trigger a --wait-for option #219

Closed
ralphbean opened this issue Feb 7, 2014 · 2 comments · Fixed by #277
Closed

Give fedmsg-trigger a --wait-for option #219

ralphbean opened this issue Feb 7, 2014 · 2 comments · Fixed by #277
Labels
core

Comments

@ralphbean
Copy link
Contributor

Currently it just runs a command as soon as it is receives a message matching its topic pattern.

It would be nice if we could have it wait for 10 seconds first so that it can accumulate a series of messages first.
@ralphbean
Copy link
Contributor Author

This would be nice for:

  • A process that listens for acl changes on packages, and then recreates the git acls on pkgs.fp.o
  • A process that listens for group changes from fas, and then runs fasclient everywhere that makes sense.

For these use cases, we should also have a --daemonize option so we can put fedmsg-trigger in the background.

@ralphbean
Copy link
Contributor Author

Maybe re-use the logic from here: https://github.com/fedora-infra/fedmsg-genacls/blob/develop/fedmsg_genacls.py#L10-L50

puiterwijk added a commit that referenced this issue Aug 18, 2014
@puiterwijk
Implement wait_for argument for fedmsg-trigger
f7a1c72 
Fixes #219
@puiterwijk puiterwijk mentioned this issue Aug 18, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement wait_for argument for fedmsg-trigger fedora-infra/fedmsg
1 participant
@ralphbean