Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the title and logo templated #32

Closed
wants to merge 4 commits into from

Conversation

puiterwijk
Copy link
Contributor

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
@@ -0,0 +1,43 @@
#!/usr/bin/env python
""" Convert our apps.yaml file to JSON, to stdout. """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring is wrong. copied.

what is this file for?

@ralphbean
Copy link
Contributor

OK. I understand now.

So, a couple more things. It doesn't make sense for yaml2data.py to be a script anymore. It should have its shebang removed since running it directly doesn't do anything anymore.

Furthermore, it doesn't make sense for it to be in a bin/ directory. It should probably go in a lib/ directory and:

  • possibly be installed into site-packages with setuptools.. and with a better name than yaml2data. Maybe apps_fp_o instead?
  • Or.. the scripts still in bin/ could use the site module to add ../lib/ to their pythonpath before trying to import it. Will this all work when they're installed via rpm?

@pypingou
Copy link
Member

@puiterwijk ping?

1 similar comment
@ralphbean
Copy link
Contributor

@puiterwijk ping?

@ralphbean
Copy link
Contributor

Closing this since there hasn't been any action on it in a while.

The branch will still be there if we want to re-open it at any point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants