Added tests for "fmn.rule.update" #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ralphbean , Sorry couldn't respond to #251 on time, due to issues with my internet conection. Please review this patch for #247 . |
| @@ -243,6 +243,35 @@ class TestConfirmationUpdateStatus(Base): | |||
| } | |||
| } | |||
|
|
|||
| class TestRuleUpdate(Base): | |||
| """ Messages of this type are published whenever **the status of a | |||
| confirmation changes** in the `Fedora Notifications | |||
There was a problem hiding this comment.
I'm not sure what you mean by the status of a confirmation changes here, maybe we could rephrase this a bit
There was a problem hiding this comment.
Yeah, the text here should be revised to something that reflects the actual message being tested. Something like a rule is updated or something similarly vague would be fine. :)
There was a problem hiding this comment.
Oops, copy paste error, :D , Fixing it.
|
👍 to merge, @ghost-script. Thanks! |
codenamesubho
added a commit
that referenced
this pull request
Apr 25, 2015
Added tests for "fmn.rule.update"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Bug: #247