Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle some pkgdb messages that we previously didn't. #128

Merged
merged 2 commits into from Aug 18, 2014
Merged

Handle some pkgdb messages that we previously didn't. #128

merged 2 commits into from Aug 18, 2014

Conversation

ralphbean
Copy link
Contributor

This should fix #127.

@pypingou
Copy link
Member

👍 for me with the remark I've made on irc:

pingou | threebean: I was just wondering if we shouldn't change our 'pkgdb.package.delete' in msg['topic'] by a msg['topic'].endswith('pkgdb.package.delete')

but that would be valid for all our classes so maybe for a later change (if we think it's a good idea)

ralphbean added a commit that referenced this pull request Aug 18, 2014
@ralphbean
Merge pull request #128 from fedora-infra/feature/those-other-pkgdb-m…
c9ab3f9 
…essages

Handle some pkgdb messages that we previously didn't.
@ralphbean ralphbean merged commit c9ab3f9 into develop Aug 18, 2014
@ralphbean ralphbean deleted the feature/those-other-pkgdb-messages branch August 18, 2014 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pkgdb NotImplementedErrors
2 participants
@ralphbean @pypingou