Strip leading v from versions before we compare them. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't really want to go this road because I thought we could use this to teach upstreams to be consistent in their release naming, but ok 👍 |
But projects which have already switched format cannot rewrite their release history. Ansible, for instance, already has github tags in two different formats and I don't think we can argue that they should go back and rename the old ones. Plus, teaching all upstreams something is probably a sisyphean task. 😉 |
ralphbean
added a commit
that referenced
this pull request
Mar 26, 2015
Strip leading v from versions before we compare them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda fixes #110.