Xmlrpc #33
Merged
Xmlrpc #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tries to make the code a bit more clearer by using simpler tests to check the results from the database. The existing comments are also extended to make it clearer what is happening.
The functionality to disable/enable a host via report_mirror used to be part of the model.Host class. It has moved to a standalone function and therefore can no longer access the model.Host fields via self.. The functionality to disable/enable host has also been moved to an earlier step where the host data is modified and not the HostCategory data.
The check if report_mirror included the 'dirtree' can be made much earlier and thus removing one indentation level.
|
Cool, 👍 for me |
|
btw @adrianreber feel free to poke me when you want me to cut a new release, there has been quite some changes since the last one, so let me know when you want one :) |
|
I am just going to merge this now to reduce the number of open pull-requests :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first change makes the XMLRPC interface actually work again. The subsequent changes are trying to simplify the code, add more comments and move code to the "right" location (related to architectural changes of the MM2 rewrite).