Spec URL: http://ralph.fedorapeople.org//nodejs-open.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-open-0.0.5-1.fc20.src.rpm Description: Open a file or url in the user's preferred application.
Review: + mock build is successful for f22 - rpmlint output on rpms gave nodejs-open.src: W: spelling-error Summary(en_US) url -> URL, curl, purl nodejs-open.src: W: spelling-error %description -l en_US url -> URL, curl, purl nodejs-open.x86_64: W: spelling-error Summary(en_US) url -> URL, curl, purl nodejs-open.x86_64: W: spelling-error %description -l en_US url -> URL, curl, purl nodejs-open.x86_64: E: no-binary nodejs-open.x86_64: W: only-non-binary-in-usr-lib nodejs-open.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/nodejs-open/LICENSE nodejs-open-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 6 warnings. ==> See suggestion below + Source verified with upstream as (sha256sum) srpm tarball :f5e85c2037b9355b7acbdc7459030027555bf08b01cb6d4db6712655dd39060a upstream tarball :f5e85c2037b9355b7acbdc7459030027555bf08b01cb6d4db6712655dd39060a + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines suggestions: 1) Add following to spec BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif
Bump with noarch: Spec URL: http://threebean.org/rpm/SPECS/nodejs-open.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-open-0.0.5-2.fc20.src.rpm
Thanks for the update. New srpm looks good. APPROVED.
New Package SCM Request ======================= Package Name: nodejs-open Short Description: Open a file or url in the user's preferred application Upstream URL: https://npmjs.org/package/open Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC:
Git done (by process-git-requests).
nodejs-open-0.0.5-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-open-0.0.5-2.fc20
nodejs-open-0.0.5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-open-0.0.5-2.fc19
Buildroot overrides have been submitted.
nodejs-open-0.0.5-2.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-open-0.0.5-2.fc19 has been pushed to the Fedora 19 stable repository.