Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Fix orphaning package having a group as PoC #161

Merged
merged 6 commits into from Feb 23, 2015
Merged

Fix orphaning package having a group as PoC #161

merged 6 commits into from Feb 23, 2015

Conversation

pypingou
Copy link
Member

No description provided.

@pypingou
Use the previous declared variable to make things easier to read
fcd21cc
@pypingou
Figure out the bugzilla email of the previous PoC if it is a group
9d2001b
@pypingou
Validate the user if it is not a group.
bf5db6d 
The user check is simpler than the PoC check but we have already checked
the validity of the PoC if the new status is Approved or Awaiting Review
@pypingou
Copy link
Member Author

This also fixes giving a package to a group

@ralphbean
Copy link
Contributor

👍

@pypingou
Copy link
Member Author

I'll try to work on a couple of unit-tests before merging, but then I'll do it directly, thanks for the review!

@pypingou pypingou mentioned this pull request Feb 22, 2015
Closed
@ralphbean
Copy link
Contributor

👍 again after e0d1b09.

pypingou added a commit that referenced this pull request Feb 23, 2015
@pypingou
Merge pull request #161 from fedora-infra/fix_orphan_group
e7e5358 
Fix orphaning package having a group as PoC
@pypingou pypingou merged commit e7e5358 into master Feb 23, 2015
@pypingou pypingou deleted the fix_orphan_group branch February 23, 2015 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pypingou @ralphbean