More info when mapping a project fails #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a mapping fails because there is already a package with this name on that distribution, until now we only mentioned this to the user, now we are also saying as part of which project this package can be found. Fixes #98
|
Can we provide a link to the other project so people can go inspect it? |
|
I thought about this but it'll appear escaped. We could turn off autoescape for flash messages I guess |
|
Hm, looking further, this will be hard as the error message is generated in the backend library which has thus not access to flask :-/ |
|
Oh well, then. 👍 |
This allows us, for example, to put a link in those messages
Unless for a database error, this will be due to the mapping already existing
…the error message
|
Much better. Thanks! 👍 |
pypingou
added a commit
that referenced
this pull request
Feb 25, 2015
More info when mapping a project fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.