Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally shorten links in IRC. #291

Merged
merged 1 commit into from Oct 7, 2014
Merged

Conversation

ralphbean
Copy link
Contributor

The #fedora-docs group was interested in this.

@pypingou
Copy link
Member

pypingou commented Oct 7, 2014

👍

The #fedora-docs group was interested in this.
ralphbean added a commit that referenced this pull request Oct 7, 2014
@ralphbean ralphbean merged commit 162c9b8 into develop Oct 7, 2014
@ralphbean ralphbean deleted the feature/optional-shortening branch October 7, 2014 14:06
@@ -145,12 +146,13 @@ class Fedmsg2IRCFactory(protocol.ClientFactory):
protocol = make_irc_client

def __init__(self, channel, nickname, filters,
pretty, terse, parent_consumer):
pretty, terse, short, parent_consumer):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering about making short be short=False but it can't since parent_consumer must be the latest argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants