Skip to content
This repository has been archived by the owner on Jul 24, 2018. It is now read-only.

Render releng dash from statscache #22

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Render releng dash from statscache #22

wants to merge 6 commits into from

Conversation

rtnpro
Copy link
Contributor

@rtnpro rtnpro commented Jun 3, 2015

This is still in experimental feature: rendering releng dashboard from statscache data.

rtnpro added 4 commits May 9, 2015 20:30
till the time this logic is moved to the statscache API.
… layout.

- Render taking into account params in component data and default options data in statscache layout
- Overrode default #if block helper of Handlebars to allow calling Handlebars helpers as conditionals
- Added couple of new Handlebars helper methods.
@ralphbean
Copy link
Contributor

Making a note here in the interest of transparency:

  • We talked about merging this and trying it out only after statscache was deployed.
  • Statscache has now been deployed, but I haven't yet had time to follow up on it and analyze it for bugs or bad behavior. Once we can do that, we can try this PR out again.. and test it against the live production data.

After that, let's merge and deploy. Sorry for the months and months of delay here.

@rtnpro
Copy link
Contributor Author

rtnpro commented Dec 4, 2015

@ralphbean Do we have a plan to test the live instance of statscache for possible bugs, bad behavior, etc?

@ralphbean
Copy link
Contributor

Do we have a plan to test the live instance of statscache for possible bugs, bad behavior, etc?

No, nothing concrete yet.

@rtnpro
Copy link
Contributor Author

rtnpro commented Dec 4, 2015

@ralphbean
can we catch up sometime to discuss on possible ways to test statscache? I will create an issue on statscache to kick off the discussion.

@pypingou
Copy link
Member

Looks like this is now conflicting, should we rebase or just close?

@ralphbean
Copy link
Contributor

I fully intend to merge this.. there's just lots of other work that still needs to be done. Like @rtnpro was asking about -- we need a plan to 1) test statscache 2) fix any problems that come up and 3) verify this change works.

@pypingou, merge conflicts are usually a problem, but not here. This is a total rewrite of the site to use statscache instead of datagrepper for backend and to use other technologies on the frontend as well.

@ralphbean
Copy link
Contributor

merge conflicts are usually a problem, but not here.

When we merge this, we'll just blow away the existing main branch.

@pypingou
Copy link
Member

ok cool :)

@ralphbean
Copy link
Contributor

@rtnpro, you should know that there's a discussion on the rel-eng list about retiiring releng-dash in favor of the new https://pdc.fedoraproject.org/ app: https://lists.fedoraproject.org/archives/list/rel-eng@lists.fedoraproject.org/thread/LOWVTF6WTS43LNPWDEISLXUELXAH5YXR/#LOWVTF6WTS43LNPWDEISLXUELXAH5YXR

@rtnpro
Copy link
Contributor Author

rtnpro commented Mar 3, 2016

So, is there any scope of consuming statscsche in PDC?
On Mar 3, 2016 9:26 PM, "Ralph Bean" notifications@github.com wrote:

@rtnpro https://github.com/rtnpro, you should know that there's a
discussion on the rel-eng list about retiiring releng-dash in favor of the
new https://pdc.fedoraproject.org/ app:
https://lists.fedoraproject.org/archives/list/rel-eng@lists.fedoraproject.org/thread/LOWVTF6WTS43LNPWDEISLXUELXAH5YXR/#LOWVTF6WTS43LNPWDEISLXUELXAH5YXR


Reply to this email directly or view it on GitHub
#22 (comment)
.

@ralphbean
Copy link
Contributor

We could wire up statscache to cache PDC events too, yes. (Although we first have to enable the PDC hook to publish fedmsg messages. It already has such a hook, we just don't have it turned on.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants