Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check existing projects while adding a new one #90

Merged
merged 8 commits into from Feb 23, 2015
Merged

Conversation

pypingou
Copy link
Member

Fixes #85

We check if a project already has the same name or homepage while we
are adding them.
Otherwise when the name and the homepage were filled and the name changed
the list was still the one for the homepage since it was the first one
checked
@puiterwijk
Copy link
Contributor

Could you maybe put the html already in the template but then have it enabled (unhidden) by javascript, rather than creating the entire block in JS itself?
Makes it easier to modify the template I think.

👍.

@@ -115,11 +125,52 @@

};

function show_project(_url, type) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename to show_similar_project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure why not, but it's not used anywhere else than this template/page

@puiterwijk
Copy link
Contributor

Looks good to me. :shipit:

pypingou added a commit that referenced this pull request Feb 23, 2015
Check existing projects while adding a new one
@pypingou pypingou merged commit d9f171b into master Feb 23, 2015
@pypingou pypingou deleted the check_while_adding branch February 23, 2015 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check whether projects already exist while adding them
2 participants