Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 error on "about" page when logged in #82

Closed
ktdreyer opened this issue Mar 27, 2015 · 1 comment · Fixed by fedora-infra/fmn.web#63
Closed

500 error on "about" page when logged in #82

ktdreyer opened this issue Mar 27, 2015 · 1 comment · Fixed by fedora-infra/fmn.web#63

Comments

@ktdreyer
Copy link

Steps to reproduce:

  1. Log in
  2. Click the "about" link in the header (https://apps.fedoraproject.org/notifications/about)

Results:
"500 Internal server error"

Expected results:
Web page displays normally

Additional info:
I can only reproduce this crash when logged in. When I clear my browser's cookies, https://apps.fedoraproject.org/notifications/about works fine.

@ktdreyer ktdreyer changed the title 500 error on "about" page 500 error on "about" page when logged in Mar 27, 2015
@ralphbean
Copy link

Yeah, this is a regression that got introduced earlier in the week. Sorry!

jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
When retrieving the users in a group we're only interested in their username
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
Open/Close the connection to rabbitmq every time we need one
jeremycline pushed a commit that referenced this issue Apr 26, 2017
This is a weird little regression that comes from trying to make the interface
more flexible for admins.  To explain:

The ``openid`` value here is the openid of the person on the page you're
looking at (for all pages.. this is the master.html template from which all
other templates inherit).  The ``logged_in_user`` here is the openid of, you
guessed it, the logged in user.

So, when you're the admin ralph.id.fedoraproject.org and you're looking at the
profile of kevin.id.fedoraproject.org.  Those links for the context are
supposed to make it easy to just click the 'irc' link in the top nav menu to
take you to kevin's irc preferences.. even though you're logged in as the admin
ralph.

That worked fine on most pages (profiles, contexts, filters, etc...) because
most pages *have* a user object that they are **about**.  The one exception is
the ``/about`` which is **not** about a user.. but is just a raw document.

The code in this change makes it such that when you are logged in and you are
looking at the ``/about`` page, those 'irc' and 'email' links in the navbar
take you to **your** preferences (since the ``openid`` variable is
undefined/``None``).

Fixes #82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants