Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce a linkable badge like travis-ci does #19

Closed
ralphbean opened this issue Apr 10, 2013 · 7 comments
Closed

Produce a linkable badge like travis-ci does #19

ralphbean opened this issue Apr 10, 2013 · 7 comments

Comments

@ralphbean
Copy link
Owner

so users can display us proudly in their README. :)

@pypingou
Copy link
Contributor

README, website, twitter, facebook, g+, linkedin ✨ let's not be restrictive ;-)

@ralphbean
Copy link
Owner Author

Might want to look into shields or buckler for this - http://blog.repl.ca/2013/08/buckler-v100.html

@pypingou
Copy link
Contributor

/me likes :)

@pypingou
Copy link
Contributor

I tried having a look at this but apparently we do not store the results of the pep8 run in the database.
I think this would be the first step. Then we could do something like /shield/username/reponame that would return the appropriate image using buckler.

We will probably have to define some threshold for green/orange/red, I'd propose the first threshold to be at 10 or 15, and the second 75 or 100 maybe.

@ralphbean
Copy link
Owner Author

I've been thinking some recently on how pep8.me has limited value because of how github only allows one "status" tag on a pull request at a time -- travis-ci and pep8.me fight for who gets to appear in the UI.

Even with that being the case, the shields/badges proposed in this ticket would make pep8.me worth reviving as a project since we could actually display the status consistently somewhere.

@ralphbean
Copy link
Owner Author

@pypingou we do actually store the results of the pep8 run in the database, which is how we are able to generate pages like this one:

http://pep8.me/fedora-infra/fedmsg/commits/ef2599d311692b5c526db44ce670755ccc5afacd

This Commit model has the pep8 errors and the error count:

https://github.com/ralphbean/pep8bot/blob/develop/pep8bot/models/__init__.py#L212

@pypingou
Copy link
Contributor

pypingou commented May 9, 2014

nice :)

@pypingou pypingou mentioned this issue May 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants