Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

orphan a group-maintained package #104

Closed
tomspur opened this issue Oct 31, 2014 · 9 comments
Closed

orphan a group-maintained package #104

tomspur opened this issue Oct 31, 2014 · 9 comments

Comments

@tomspur
Copy link

tomspur commented Oct 31, 2014

One can retire a package with fedpkg retire, but how can one orphan a package, that is maintained by a group?

As fedpkg retire should work for any group member, would it be possible to show a "Orphan package" button in pkgdb for any memer in that group?

Another possibility would be to show this button for any co-administrator, but I'd prefer the first option, if that's possible.

I noticed this at this package.

@rtnpro
Copy link

rtnpro commented Nov 2, 2014

I will need to reproduce this bug. I am going out of town for a office meeting tomorrow. I will be back on Wednesday. I will look into it after that. If any one wants to work on it in between, you are welcome :)

@pypingou
Copy link
Member

One thing for this is that in pkgdb only package administrators can orphan a package and groups are not administrators, they are only used to provide commits to a group of people.

So we would have to decide if we want to change this.

@pypingou
Copy link
Member

Note this relates to #103

@tomspur
Copy link
Author

tomspur commented Feb 22, 2015

I'd like to retire python3-dateutil, where I'm only admin and a group is POC.
It fails with:

$ pkgdb-cli orphan --retire python3-dateutil master
No output returned by https://admin.fedoraproject.org/pkgdb/api/package/retire/

Is this the expected output, when I'm not allowed to retire it? Or a bug in the server?

Would it be possible to let admins retire the package, if a group is the POC? This would be at least the expected solution in this case. I don't know if anyone from the group should be able to retire it or if one still requires an admin.
That would solve at least this issue until #103 is solved.

@pypingou
Copy link
Member

You're supposed to retire a package via fedpkg retire, does it make any difference?

@tomspur
Copy link
Author

tomspur commented Feb 22, 2015

I tried that first and then manually with pkgdb-cli after it failed. Running it again, I get the same output:

$ fedpkg retire "python3-dateutil is now a subpackage of python-dateutil again (#1126521)"
dead.package found, package probably already retired - will not remove files from git or overwrite existing dead.package file
Everything up-to-date
Could not retire package: No output returned by https://admin.fedoraproject.org/pkgdb//api/package/retire/

@pypingou
Copy link
Member

I think I found a couple of bugs in the process of replicating the issue.
I addressed them here: #161

@pypingou
Copy link
Member

#161 has been merged and I pushed a bugfix release with these changes.

We already fixed python3-dateutil so I'll keep this ticket opened until we can find out if the patches are working as expected.

@tomspur
Copy link
Author

tomspur commented Feb 23, 2015

The F22 branch also needed to be retired and it worked just fine.
Thanks for the fix.

@tomspur tomspur closed this as completed Feb 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants